Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker build dependent on event type #812

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

ReenigneArcher
Copy link
Member

Description

Docker build will now depend on the event type. There is a problem with slow builds when building the Fedora images for arm64 architecture. Only amd64 images are built now on PR events.

Additionally, the dockerfile syntax has been added to each dockerfile.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the docker-build-dependent-on-event-type branch from b0dd4a7 to f6a8bf3 Compare January 22, 2023 14:00
@ReenigneArcher ReenigneArcher force-pushed the docker-build-dependent-on-event-type branch from f6a8bf3 to b030f99 Compare January 22, 2023 14:09
@ReenigneArcher ReenigneArcher merged commit 3f202be into nightly Jan 22, 2023
@ReenigneArcher ReenigneArcher deleted the docker-build-dependent-on-event-type branch January 22, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant