-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning improvements #768
Versioning improvements #768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also move version.h.in
to ./src
, and rename to version.h
.
I might be wrong, but I think if we put it in ./src
we won't even need to configure this file in CMakeLists.txt like I set it up originally.
Also, there's a small typo in line 8 of version.h.in
, PROJECT_VER_PATCH
.
I've moved the file but kept the suffix, since the file is an intermediate source file. version.h is generated by Cmake
Fixed |
It seems I've broke the build, fixing this |
Build should be fixed now! |
Great! Just a few indentations to fix now in |
ef502c9
to
7b7f9a0
Compare
When I updated the branch, I did so with a re-base and it removed the merge commits. I didn't know that would happen, but now I have a question. Is this going to work reliably when building nightly builds (or PR builds), as we don't typically merge |
The PR uses git for tag handling (it uses the |
Update Nightly
The PR has now been updated to use the version number inside the CMakeLists.txt. |
@TheElixZammuto Todo:
|
41dffbf
to
0658549
Compare
0658549
to
8a2d218
Compare
@TheElixZammuto I fixed a couple of things in the builds, but still getting a dirty git tree in the docker builds. Any idea? I suppose it's not copying the |
…unshine-1 into versioning-improvements
5faf1df
to
d6b8c19
Compare
d6b8c19
to
1357d7d
Compare
03c7235
to
70ef55f
Compare
70ef55f
to
268c5e1
Compare
Description
This PR adds an improved versioning system.
CMake has been modified to add support to https://github.com/nocnokneo/cmake-git-versioning-example, so it uses
git describe
to get the git tag, the current commit and if the commit tree is dirty.The Sunshine version has been prepended to the stdout for troubleshooting.
In the index.html file of the Web UI, communication with the GitHub API has been added, for fetching the latest version and letting the user know if a new version is available. release users only get notices of releases, while nightly users get both release and the last successful CI in the Ci.yaml
For making the tag sync with the current master (0.17), I've merged master into nightly (there are only some merge commits)
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.