Enforce 10 FPS encoding frame rate floor to improve static image quality #754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our variable frame rate encoding scheme has a major issue with static content because the RC buffer limit can be reached and additional frames are required to fill in additional detail (which will never come if the image is static). This PR improves image quality in that situation by encoding the previous frame again if the capture frame rate drops below 10 FPS.
You can easily see this effect if you connect with Moonlight Qt at low bitrate with a complex scene displayed on the host and then resize the Moonlight window (which triggers a key frame).
We probably want to move to fixed rate encoding, but this is a very simple stop-gap until we do that work.
Screenshot
Issues Fixed or Closed
Fixes #717
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.