Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce 10 FPS encoding frame rate floor to improve static image quality #754

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Jan 11, 2023

Description

Our variable frame rate encoding scheme has a major issue with static content because the RC buffer limit can be reached and additional frames are required to fill in additional detail (which will never come if the image is static). This PR improves image quality in that situation by encoding the previous frame again if the capture frame rate drops below 10 FPS.

You can easily see this effect if you connect with Moonlight Qt at low bitrate with a complex scene displayed on the host and then resize the Moonlight window (which triggers a key frame).

We probably want to move to fixed rate encoding, but this is a very simple stop-gap until we do that work.

Screenshot

Issues Fixed or Closed

Fixes #717

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants