Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web ui #43

Merged
merged 7 commits into from
Feb 13, 2022
Merged

Update web ui #43

merged 7 commits into from
Feb 13, 2022

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Feb 5, 2022 •
edited
Loading

Description

  • Add fontawesome
  • Add favicon
  • Add logo
  • Add support and legal links to index.html
  • Improve layout of index.html
  • Improve layout of navbar

Screenshot

image

Issues Fixed or Closed

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the documentation blocks for new or existing components

@ReenigneArcher
Update web ui
9f4ad53 
- Add fontawesome
- Add favicon
- Add logo
- Add support and legal links to index.html
- Improve layout of index.html
- Improve layout of navbar
@ReenigneArcher ReenigneArcher marked this pull request as ready for review February 5, 2022 23:22
ReenigneArcher
ReenigneArcher commented Feb 6, 2022
View reviewed changes
Copy link
Member Author

@ReenigneArcher ReenigneArcher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheElixZammuto or @cfajardo any ideas

assets/web/header.html Outdated Show resolved Hide resolved
sunshine/confighttp.cpp Outdated Show resolved Hide resolved
sunshine/confighttp.cpp Outdated Show resolved Hide resolved
ReenigneArcher
ReenigneArcher commented Feb 9, 2022
View reviewed changes
Copy link
Member Author

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix .ico and css (stylesheet)

assets/web/header.html Outdated Show resolved Hide resolved
assets/web/header.html Show resolved Hide resolved
@ReenigneArcher
Copy link
Member Author

@TheElixZammuto Okay, for the fontawesome, I am serving the 3 required files manually (css, and two tff files). I've also included the other *min.css files, and other webfonts even though they are not being used (will be easier to utilize them later if needed). Tested and everything seems to be working (logo, favicon, and font-awesome icons).

Also, safe to make release v0.12.0 after this PR?

@ReenigneArcher ReenigneArcher linked an issue Feb 12, 2022 that may be closed by this pull request
Add NOTICE/LICENSE to release packages #41
Closed
@TheElixZammuto
Copy link
Contributor

Tested on Windows, looks okay and it works, LGTM

@ReenigneArcher ReenigneArcher merged commit cf8a843 into nightly Feb 13, 2022
@ReenigneArcher ReenigneArcher deleted the update-web-ui branch February 13, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PapyKahan PapyKahan PapyKahan left review comments

@TheElixZammuto TheElixZammuto TheElixZammuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NOTICE/LICENSE to release packages
3 participants
@ReenigneArcher @TheElixZammuto @PapyKahan