Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-ui): fix new version notification conditions #3577

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

The logic to check compare the versions was slightly wrong as there was no logic to handle when the version part was less than the other version part.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) January 22, 2025 00:18
@ReenigneArcher ReenigneArcher added this to the stable release milestone Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.66%. Comparing base (5af21bd) to head (1b1fb5f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #3577     +/-   ##
=========================================
  Coverage   11.66%   11.66%             
=========================================
  Files          93       93             
  Lines       17304    17304             
  Branches     8089     8089             
=========================================
  Hits         2018     2018             
+ Misses      14692    12806   -1886     
- Partials      594     2480   +1886     
Flag Coverage Δ
Linux 11.35% <ø> (ø)
Windows 13.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompted to downgrade?
1 participant