Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake/windows): static link MinHook #3537

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

FrogTheFrog
Copy link
Collaborator

@FrogTheFrog FrogTheFrog commented Jan 15, 2025

Description

Static linking for minhook.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.30%. Comparing base (d4052dc) to head (c2b7361).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3537      +/-   ##
==========================================
- Coverage   10.34%   10.30%   -0.05%     
==========================================
  Files          90       90              
  Lines       16130    16130              
  Branches     7655     7655              
==========================================
- Hits         1669     1662       -7     
- Misses      13907    13911       +4     
- Partials      554      557       +3     
Flag Coverage Δ
Linux 9.68% <ø> (-0.07%) ⬇️
Windows 10.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@FrogTheFrog FrogTheFrog changed the title fix(minhook): package dll with cpack fix(cmake/windows): static link MinHook Jan 15, 2025
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) January 15, 2025 18:53
@ReenigneArcher ReenigneArcher merged commit 7f0351d into LizardByte:master Jan 15, 2025
37 checks passed
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants