fix(capture/windows): fix capture when using the basic render driver #3531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the longest time, I thought DDA just didn't work on the Microsoft Basic Display Adapter. It turns out that it works fine, but we're passing a D3D11 device flag that it doesn't support so we fail to create the D3D11 device with
DXGI_ERROR_UNSUPPORTED
. I reviewed several DDA samples online (including the official Microsoft one) and none of them set thisD3D11_CREATE_DEVICE_VIDEO_SUPPORT
flag.It's not completely clear what
D3D11_CREATE_DEVICE_VIDEO_SUPPORT
even does exactly, but assuming it's required for the device where we do video encoding/processing, let's just set it on the device that FFmpeg uses for encoding.Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist