Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(capture/macos): fix implicit conversion of NSArray #3502

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Dec 31, 2024

Description

Fixes the following compiler warnings on macOS:

src/platform/macos/av_video.m:35:13: warning: incompatible pointer types initializing 'NSScreen *' with an expression of type 'NSArray<NSScreen *> * _Nonnull' [-Wincompatible-pointer-types]
   35 |   NSScreen *screens = [NSScreen screens];
      |             ^         ~~~~~~~~~~~~~~~~~~
src/platform/macos/av_video.m:36:3: warning: collection expression type 'NSScreen *' may not respond to 'countByEnumeratingWithState:objects:count:'
   36 |   for (NSScreen *screen in screens) {
      |   ^  

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.87%. Comparing base (d50611c) to head (fcd2222).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3502   +/-   ##
======================================
  Coverage    7.87%   7.87%           
======================================
  Files          90      90           
  Lines       15803   15803           
  Branches     7487    7487           
======================================
  Hits         1244    1244           
  Misses      12133   12133           
  Partials     2426    2426           
Flag Coverage Δ
Linux 8.42% <ø> (ø)
Windows 5.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher
Copy link
Member

Any idea why this didn't cause failures in CI? Errors should cause a failure.

if(BUILD_WERROR)
list(APPEND SUNSHINE_COMPILE_OPTIONS -Werror)
endif()

Copy link

sonarqubecloud bot commented Jan 3, 2025

@ReenigneArcher ReenigneArcher merged commit 151ff8f into LizardByte:master Jan 3, 2025
35 of 37 checks passed
@cgutman
Copy link
Collaborator Author

cgutman commented Jan 8, 2025

Any idea why this didn't cause failures in CI? Errors should cause a failure.

I don't think SUNSHINE_COMPILE_OPTIONS is passed to the Objective-C compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants