Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hostname): fix handling of non-ASCII hostnames on Windows #3382

Merged
merged 2 commits into from
Nov 9, 2024

Update tests/unit/platform/test_common.cpp

c44ca2d
Select commit
Loading
Failed to load commit list.
Merged

fix(hostname): fix handling of non-ASCII hostnames on Windows #3382

Update tests/unit/platform/test_common.cpp
c44ca2d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 9, 2024 in 0s

40.00% of diff hit (target 11.05%)

View this Pull Request on Codecov

40.00% of diff hit (target 11.05%)

Annotations

Check warning on line 549 in src/platform/macos/misc.mm

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/platform/macos/misc.mm#L549 

Added line #L549 was not covered by tests

Check warning on line 1854 in src/platform/windows/misc.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/platform/windows/misc.cpp#L1854 

Added line #L1854 was not covered by tests
View more details on Codecov