Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nvenc): disable filler data in AV1 bitstream #3336

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Oct 29, 2024

Description

Disable padding OBU insertion in AV1 bitstreams from FFmpeg NVENC to match the standalone NVENC implementation and avoid wasted bandwidth and compatibility issues with Snapdragon 8 Gen 3 decoders.

Screenshot

Issues Fixed or Closed

Fixes #3331

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.14%. Comparing base (8810c5c) to head (5075069).
Report is 96 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3336   +/-   ##
=======================================
  Coverage   11.14%   11.14%           
=======================================
  Files          99       99           
  Lines       17184    17183    -1     
  Branches     8009     8009           
=======================================
  Hits         1915     1915           
+ Misses      12658    12580   -78     
- Partials     2611     2688   +77     
Flag Coverage Δ
Linux 8.45% <ø> (ø)
Windows 5.22% <ø> (ø)
macOS-13 13.65% <ø> (+<0.01%) ⬆️
macOS-14 12.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/video.cpp 30.34% <ø> (+0.02%) ⬆️

... and 22 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to decode AV1 stream generated by NVENC on sunshine linux in capable hardware
1 participant