Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vaapi): add option to enable strict enforcement of frame size #3332

Merged
merged 2 commits into from
Nov 1, 2024

Eliminate the QP fallback code that was only required for VAAPI

61362c1
Select commit
Loading
Failed to load commit list.
Merged

feat(vaapi): add option to enable strict enforcement of frame size #3332

Eliminate the QP fallback code that was only required for VAAPI
61362c1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2024 in 0s

11.06% (-0.13%) compared to 9662f05

View this Pull Request on Codecov

11.06% (-0.13%) compared to 9662f05

Details

Codecov Report

Attention: Patch coverage is 8.60215% with 85 lines in your changes missing coverage. Please review.

Project coverage is 11.06%. Comparing base (9662f05) to head (61362c1).

Files with missing lines Patch % Lines
src/platform/linux/vaapi.cpp 0.00% 74 Missing ⚠️
src/video.cpp 37.50% 4 Missing and 6 partials ⚠️
src/config.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
- Coverage   11.18%   11.06%   -0.13%     
==========================================
  Files          99       99              
  Lines       17184    17231      +47     
  Branches     8008     8034      +26     
==========================================
- Hits         1922     1906      -16     
+ Misses      12719    12641      -78     
- Partials     2543     2684     +141     
Files with missing lines Coverage Δ
src/config.h 0.00% <ø> (ø)
src/platform/common.h 34.04% <100.00%> (ø)
src/video.h 54.94% <ø> (+0.59%) ⬆️
src/config.cpp 6.00% <50.00%> (+0.30%) ⬆️
src/video.cpp 29.95% <37.50%> (-0.47%) ⬇️
src/platform/linux/vaapi.cpp 2.35% <0.00%> (-0.93%) ⬇️

... and 21 files with indirect coverage changes