-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(audio/windows): don't set virtual speakers higher than 24-bit mode #3294
fix(audio/windows): don't set virtual speakers higher than 24-bit mode #3294
Conversation
@ns6089 thoughts? |
Here's the related thread on discord: https://discord.com/channels/804382334370578482/1293704798574743625 |
@cgutman Should be fine I think. |
…bering spatial audio settings
b4b4ad8
to
3bd6a56
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3294 +/- ##
==========================================
- Coverage 11.14% 11.13% -0.02%
==========================================
Files 99 99
Lines 17213 17211 -2
Branches 8023 8023
==========================================
- Hits 1918 1916 -2
Misses 12737 12737
Partials 2558 2558
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LizardByte#3294) Windows: don't try to set Steam speakers to 32-bit mode to avoid clobbering spatial audio settings
Description
When the Moonlight "Mute host PC speakers" option is selected, Sunshine will change the audio device to Steam Speakers. The changed block of code cycles through some settings in order and stops on the first one found, which happens to be the 32-bit signed int format. What we really want to happen is to have 24-bit as the highest supported format because this mode won't unset an existing spatial audio mode (Atmos for Headphones only supports 16 and 24-bit at <= 48k.
This patch simply removes the F32 and S32 checks for stereo. F32 isn't supported by Steam Speakers, but S32 is and that's the one we want to avoid.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist