Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fedora)!: add copr build #3239

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Sep 29, 2024

Description

Add fedora copr build spec. Final build will be here: https://copr.fedorainfracloud.org/coprs/lizardbyte/Sunshine/

Todo:

  • trigger copr build from PRs and push events
  • dynamically get version number
  • cuda for aarch64
  • one cmake call
  • remove fedora docker builds
  • update docs
  • unit tests pass
  • cuda improvements (in f40+)
  • remove og spec file

References:

Screenshot

image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.74%. Comparing base (0107ca4) to head (c93caf2).
Report is 91 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #3239    +/-   ##
=======================================
  Coverage    9.74%   9.74%            
=======================================
  Files         101     101            
  Lines       17972   17972            
  Branches     8417    8417            
=======================================
  Hits         1751    1751            
+ Misses      13480   13330   -150     
- Partials     2741    2891   +150     
Flag Coverage Δ
Linux 7.27% <ø> (ø)
Windows 5.10% <ø> (ø)
macOS-13 10.54% <ø> (ø)
macOS-14 10.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

Copy link
Contributor

@matte-schwartz matte-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few replies to some of the TODOs

packaging/linux/fedora/sunshine.spec Outdated Show resolved Hide resolved
packaging/linux/fedora/sunshine.spec Outdated Show resolved Hide resolved
packaging/linux/fedora/sunshine.spec Outdated Show resolved Hide resolved
@ReenigneArcher

This comment was marked as resolved.

@matte-schwartz

This comment was marked as resolved.

@ReenigneArcher

This comment was marked as resolved.

@matte-schwartz

This comment was marked as resolved.

@ReenigneArcher ReenigneArcher force-pushed the build/fedora/add-copr-build branch 2 times, most recently from c6f307e to dfcd145 Compare October 5, 2024 16:33
Copy link

sonarqubecloud bot commented Oct 5, 2024

@ReenigneArcher ReenigneArcher force-pushed the build/fedora/add-copr-build branch 14 times, most recently from 67cda22 to 1712406 Compare October 5, 2024 22:03
@ReenigneArcher ReenigneArcher force-pushed the build/fedora/add-copr-build branch 2 times, most recently from 8733f0f to 51c9eea Compare October 5, 2024 23:41
packaging/linux/fedora/sunshine.spec Outdated Show resolved Hide resolved
packaging/linux/fedora/sunshine.spec Outdated Show resolved Hide resolved
packaging/linux/fedora/sunshine.spec Outdated Show resolved Hide resolved
packaging/linux/fedora/sunshine.spec Show resolved Hide resolved
@ReenigneArcher ReenigneArcher force-pushed the build/fedora/add-copr-build branch 11 times, most recently from a601a53 to 4acc371 Compare October 6, 2024 03:53
@ReenigneArcher ReenigneArcher marked this pull request as ready for review October 6, 2024 03:57
@ReenigneArcher ReenigneArcher requested review from matte-schwartz and cgutman and removed request for matte-schwartz October 6, 2024 03:57
@ReenigneArcher ReenigneArcher added this to the stable release milestone Oct 6, 2024
@ReenigneArcher ReenigneArcher changed the title build(fedora): add copr build build(fedora)!: add copr build Oct 6, 2024
@ReenigneArcher ReenigneArcher force-pushed the build/fedora/add-copr-build branch from 4acc371 to 58c3e86 Compare October 6, 2024 16:37
@ReenigneArcher ReenigneArcher force-pushed the build/fedora/add-copr-build branch from 58c3e86 to c93caf2 Compare October 6, 2024 18:12
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) October 6, 2024 18:16
Copy link

sonarqubecloud bot commented Oct 6, 2024

@ReenigneArcher ReenigneArcher merged commit 15b91a1 into master Oct 6, 2024
35 checks passed
@ReenigneArcher ReenigneArcher deleted the build/fedora/add-copr-build branch October 6, 2024 18:41
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants