Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reverse Proxy support #3173

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix: Reverse Proxy support #3173

merged 1 commit into from
Oct 19, 2024

Conversation

Degot
Copy link
Contributor

@Degot Degot commented Sep 12, 2024

Description

These changes allow to use sunshine webui after reverse proxy with subpath.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@Degot Degot changed the title modified URLs to allow reverse proxy + set base in vite.config Fix Reverse Proxy support Sep 12, 2024
@Degot Degot changed the title Fix Reverse Proxy support fix:Reverse Proxy support Sep 13, 2024
@ReenigneArcher

This comment was marked as resolved.

@ReenigneArcher ReenigneArcher changed the title fix:Reverse Proxy support fix: Reverse Proxy support Sep 14, 2024
@Degot

This comment was marked as resolved.

@ReenigneArcher

This comment was marked as resolved.

@Degot

This comment was marked as resolved.

@B1LL1T3R

This comment was marked as spam.

@ReenigneArcher
Copy link
Member

Perhaps, along with this PR, it would be good to update the docs with a simple example of how to use Sunshine in a reverse proxy? I think it would make sense to go here: https://github.com/LizardByte/Sunshine/blob/master/docs/guides.md , under a new ## General section.

@ReenigneArcher
Copy link
Member

Perhaps, along with this PR, it would be good to update the docs with a simple example of how to use Sunshine in a reverse proxy? I think it would make sense to go here: https://github.com/LizardByte/Sunshine/blob/master/docs/guides.md , under a new ## General section.

@Degot any thoughts?

Copy link

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.13%. Comparing base (fc78f5a) to head (116354f).
Report is 82 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3173    +/-   ##
========================================
  Coverage   11.13%   11.13%            
========================================
  Files          99       99            
  Lines       17211    17211            
  Branches     8023     8023            
========================================
  Hits         1916     1916            
- Misses      12594    12737   +143     
+ Partials     2701     2558   -143     
Flag Coverage Δ
Linux 8.42% <ø> (ø)
Windows 5.19% <ø> (ø)
macOS-13 13.61% <ø> (ø)
macOS-14 12.60% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebUI can't be used as subpath behind Nginx reverse proxy
3 participants