fix(mdns): don't hardcode mDNS instance name #3084
Merged
Codecov / codecov/project
succeeded
Aug 25, 2024 in 0s
9.54% (-0.13%) compared to f048510
View this Pull Request on Codecov
9.54% (-0.13%) compared to f048510
Details
Codecov Report
Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 9.54%. Comparing base (
f048510) to head (a7b43d3).
| Files | Patch % | Lines |
|---|---|---|
| src/platform/windows/publish.cpp | 0.00% | 3 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## master #3084 +/- ##
=========================================
- Coverage 9.66% 9.54% -0.13%
=========================================
Files 101 77 -24
Lines 17942 14040 -3902
Branches 8381 6442 -1939
=========================================
- Hits 1734 1340 -394
+ Misses 13328 10082 -3246
+ Partials 2880 2618 -262 | Files | Coverage Δ | |
|---|---|---|
| src/network.cpp | 24.56% <100.00%> (+8.87%) |
⬆️ |
| src/network.h | 0.00% <ø> (ø) |
|
| src/platform/macos/publish.cpp | 5.12% <ø> (-2.57%) |
⬇️ |
| src/platform/windows/publish.cpp | 0.00% <0.00%> (ø) |
Loading