-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(win/qsv): skip unsupported 4:4:4 codecs #3029
Conversation
6b907ac
to
4958950
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3029 +/- ##
=========================================
+ Coverage 9.67% 9.69% +0.01%
=========================================
Files 101 101
Lines 17898 17913 +15
Branches 8365 8376 +11
=========================================
+ Hits 1732 1736 +4
- Misses 13295 13306 +11
Partials 2871 2871
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to cover the H.264 case above on line 2519.
Edit: Actually, it looks like we're missing a >= 0
check on the return value of validate_config()
there. That explains the weird behavior I saw.
Updated the branch. One day we should migrate all those int-returning functions to bool. Some fail on 0, some fail on non-0, and both are implicitly convertible. |
Quality Gate passedIssues Measures |
Description
Skip particular QSV 4:4:4 codecs bypassing ffmpeg.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist