-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linux): ensure NvFBC capture works after multiple sessions #3020
Conversation
It ain't stupid if it works. |
Ok Done. |
Dirty hack testing
fixup dirty hack to actually compile
One last try at this horrible hack
Dirty debuging
No idea let's try this
Remove log lines as fix works
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3020 +/- ##
=========================================
- Coverage 9.69% 9.69% -0.01%
=========================================
Files 97 97
Lines 17524 17525 +1
Branches 8204 8204
=========================================
Hits 1699 1699
- Misses 12987 12988 +1
Partials 2838 2838
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Please excuse the code. Basically I had a suspicion that the 'ctx_t' helper in the NvFBC code path was releasing the context early and that the exhaustion of session handles was causing the "can only reconnect 2-4 times" before it fails to reconnect bug. #2974
So I tried a dirty workaround of binding the context before destroying the session handle. And guess what, it works.
I also added some error logs around when it binds and unbinds the context to confirm my suspicions.
Really the whole code needs to be reworked to ensure the ctx_t class remains in scope correctly. But that's a little above my skill level.
Issues Fixed or Closed
Fixes #2974
Type of Change
.github/...
)Checklist