-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmake): use symlink/junction for shaders in build dir #3013
feat(cmake): use symlink/junction for shaders in build dir #3013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same changes also needed for Linux.
Sunshine/cmake/packaging/linux.cmake
Lines 5 to 7 in 2996727
# copy assets to build directory, for running without install | |
file(COPY "${SUNSHINE_SOURCE_ASSETS_DIR}/linux/assets/" | |
DESTINATION "${CMAKE_BINARY_DIR}/assets") |
I wouldn't say needed. but I can make them. But I can't say for sure that it won't break some obscure build configuration or packager, unlike windows on linux copying symlinks copy symlinks themselves, not what they point at. @ReenigneArcher so in light of this information, should I do it or not? |
Right, it could just be annoyance when developing on Linux, just like it was for you on Windows. Shouldn't affect anything for packagers as I only added this for allowing unit tests to run without doing a full blown install.
Yes, please. |
81c8ca2
to
d75bc3a
Compare
Added shaders directory symlink to linux cmake. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3013 +/- ##
=======================================
Coverage 9.69% 9.69%
=======================================
Files 101 101
Lines 17913 17913
Branches 8376 8376
=======================================
Hits 1736 1736
+ Misses 13453 13313 -140
- Partials 2724 2864 +140
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Use directory junction instead of copy in the build directory during cmake configure on Windows.
This prevents work-in-progress shaders getting overwritten without any confirmation.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist