Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux/audio): don't set pulseaudio buffer size #2999

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ns6089
Copy link
Contributor

@ns6089 ns6089 commented Aug 9, 2024

Description

Don't set pulseaudio buffer size.
We only care for fragment size anyway and don't pace consumption.
Should hopefully fix audio cracking in pipewire-pulseaudio.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

We only care for fragment size anyway and don't pace consumption.
Should hopefully fix audio cracking in pipewire-pulseaudio.
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (0e153cf) to head (f69f78c).
Report is 135 commits behind head on master.

Files with missing lines Patch % Lines
src/platform/linux/audio.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2999      +/-   ##
=========================================
+ Coverage    9.57%   9.69%   +0.11%     
=========================================
  Files          73      97      +24     
  Lines       13616   17524    +3908     
  Branches     6263    8204    +1941     
=========================================
+ Hits         1304    1699     +395     
- Misses       9737   15042    +5305     
+ Partials     2575     783    -1792     
Flag Coverage Δ
Linux 7.20% <0.00%> (?)
Windows 5.11% <ø> (ø)
macOS-12 10.35% <ø> (ø)
macOS-13 10.26% <ø> (ø)
macOS-14 10.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/audio.cpp 9.64% <0.00%> (ø)

... and 55 files with indirect coverage changes

.tlength = uint32_t(-1),
.prebuf = uint32_t(-1),
.minreq = uint32_t(-1),
.fragsize = uint32_t(frame_size * channels * sizeof(float))

Check failure

Code scanning / CodeQL

Multiplication result converted to larger type

Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'.
@ns6089
Copy link
Contributor Author

ns6089 commented Aug 9, 2024

Got the confirmation that it fixes the pipewire related bug, should be ok to merge.

@ReenigneArcher ReenigneArcher changed the title Don't set pulseaudio buffer size fix(linux/audio): don't set pulseaudio buffer size Aug 9, 2024
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) August 9, 2024 20:16
@ReenigneArcher ReenigneArcher merged commit f9c885a into LizardByte:master Aug 9, 2024
47 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux audio broken after update to float
2 participants