Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cmake): set CMAKE_PROJECT_VERSION from PROJECT_VERSION #2936

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Cpack binaries are getting version 0.0.0, although the --version is correct as well as what's in the web UI. This should fix that.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.57%. Comparing base (459c604) to head (ddf9605).
Report is 132 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2936   +/-   ##
======================================
  Coverage    9.57%   9.57%           
======================================
  Files          97      97           
  Lines       17582   17582           
  Branches     8336    8336           
======================================
  Hits         1683    1683           
  Misses      13011   13011           
  Partials     2888    2888           
Flag Coverage Δ
Linux 6.95% <ø> (ø)
Windows 5.08% <ø> (ø)
macOS-12 10.29% <ø> (ø)
macOS-13 10.20% <ø> (ø)
macOS-14 10.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher merged commit 444ca98 into master Jul 30, 2024
47 checks passed
@ReenigneArcher ReenigneArcher deleted the ReenigneArcher-patch-1 branch July 30, 2024 19:15
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants