Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission for Flatpak. #291

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Add permission for Flatpak. #291

merged 2 commits into from
Aug 1, 2022

Conversation

istori1
Copy link
Contributor

@istori1 istori1 commented Jul 31, 2022

Description

Adding --talk-name=org.freedesktop.Flatpak as this is needed to launch applications on the host. Example: flatpak-spawn --host sleep 1m.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

Adding --talk-name=org.freedesktop.Flatpak as this is needed to launch applications on the host. Example flatpak-spawn --host sleep 1m.
@CLAassistant
Copy link

CLAassistant commented Jul 31, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any documentation update needed for this?

@istori1
Copy link
Contributor Author

istori1 commented Jul 31, 2022

We should document using "flatpak-spawn --host app/game executable"

@ReenigneArcher
Copy link
Member

@istori1
Copy link
Contributor Author

istori1 commented Aug 1, 2022

We should document using "flatpak-spawn --host app/game executable"

Perhaps it should be defined in this section? https://github.com/istori1/Sunshine/blob/patch-2/docs/source/about/usage.rst#application-list

OR https://github.com/istori1/Sunshine/blob/patch-2/docs/source/troubleshooting/linux.rst#linux

It should be in the usage section.

@ReenigneArcher ReenigneArcher merged commit 58a71bf into LizardByte:nightly Aug 1, 2022
@istori1 istori1 deleted the patch-2 branch September 12, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants