Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(display)!: Add libdisplaydevice dependency and output name mapping #2894

Merged
merged 1 commit into from
Dec 11, 2024

feat: Add libdisplaydevice dependency and output name mapping

7293c10
Select commit
Loading
Failed to load commit list.
Merged

feat(display)!: Add libdisplaydevice dependency and output name mapping #2894

feat: Add libdisplaydevice dependency and output name mapping
7293c10
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 0s

11.16% (+0.03%) compared to 0cc98f1

View this Pull Request on Codecov

11.16% (+0.03%) compared to 0cc98f1

Details

Codecov Report

Attention: Patch coverage is 22.58065% with 48 lines in your changes missing coverage. Please review.

Project coverage is 11.16%. Comparing base (0cc98f1) to head (7293c10).

Files with missing lines Patch % Lines
src/display_device.cpp 13.04% 16 Missing and 4 partials ⚠️
src/logging.cpp 28.57% 14 Missing and 6 partials ⚠️
src/video.cpp 37.50% 3 Missing and 2 partials ⚠️
src/platform/windows/display_base.cpp 0.00% 2 Missing ⚠️
src/platform/macos/input.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2894      +/-   ##
==========================================
+ Coverage   11.12%   11.16%   +0.03%     
==========================================
  Files          99      100       +1     
  Lines       17253    17310      +57     
  Branches     8045     8069      +24     
==========================================
+ Hits         1920     1933      +13     
- Misses      12779    12812      +33     
- Partials     2554     2565      +11     
Files with missing lines Coverage Δ
src/logging.h 32.35% <ø> (ø)
src/platform/macos/input.cpp 40.86% <0.00%> (-0.23%) ⬇️
src/platform/windows/display_base.cpp 13.46% <0.00%> (-0.03%) ⬇️
src/video.cpp 30.00% <37.50%> (+0.04%) ⬆️
src/display_device.cpp 13.04% <13.04%> (ø)
src/logging.cpp 60.71% <28.57%> (-7.43%) ⬇️