Implement S/G IO for non-batched sends and eliminate more data copies #2867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements scatter/gather I/O support in the platform socket code for non-batched sends. Because we can specify separate header and payload buffers, this allows us to eliminate all redundant copies of audio shards. The performance impact of this change alone is quite small, but it will reduce the complexity of the following PR that implements S/G for batched sends.
I also included a drive-by fix for another missing
std::vector::reserve()
call that was causing horrible performance when usingstd::copy()
withstd::back_iterator()
.Testing checklist:
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.