-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.11.1 #27
Merged
Merged
v0.11.1 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Fix syntax error
-Attempt to fix build step at line 56 -Various tweaks to quoting and directory names
-Checkout recursively with submodules
-recursive submodules -only run on PR for master or nightly branch
Add build checks (just AppImage for now)
-Add deb job with matrix strategy
-build with -u for non interactive
-Fix command that moves deb package -Separate setup, build, and package steps
-Fix permission denied error when moving deb package
-Add Windows build
-Fix path issue for pacman command
-Boost debug on
-Install boost -Remove boost debug during cmake
-Fix boost install directory
-Add environment variable BOOST_ROOT
-Try older version of boost, new version failing with cmake 3.22
-Try boost v1.73.0 built on windows server 2019
-Try boost 1.72.0
-Remove push event for add-build-checks
Add build checks
Update CHANGELOG.md
-Fix typo in Windows build
Update create_package.yml
- github.base_ref is needed for pull request check
-Verify changelog requires checkout
Update create_package.yml
Automated PR tests and releases
Update changelog
I know that everything in this PR has already been reviewed once when it was merged into |
Like I said before I'm not a huge GitHub Actions user, but it seems okay to me (especially the Windows side which I'm more accustomed to), LGTM |
TheElixZammuto
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CHANGELOG.md
and update history.github
filescreate_package.yml
(Responsible for PR build tests, Packaging, Automating Releases when push intomaster
branch)create_package.yml
)update-alternatives
instead ofcp
for gcc on Ubuntu 20.04Note: Once this is merged. The workflow should run and attempt to create a release. The release will fail because the latest version from the CHANGELOG.md matches the latest released version (v0.11.1); however getting this into
master
will setup the automation for all future PRs.Type of Change
Please delete options that are not relevant.
Checklist