Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(linux/fedora): Reenable Cuda support by building with gcc-12 #2654

Closed
wants to merge 6 commits into from

Conversation

Crashdummyy
Copy link
Contributor

@Crashdummyy Crashdummyy commented Jun 9, 2024

Description

Reenable cuda again by compiling it using cuda-gcc-c++

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Duplicates #2649

@ReenigneArcher ReenigneArcher marked this pull request as draft June 9, 2024 02:36
@ReenigneArcher ReenigneArcher changed the title WIP: Reenable Cuda support by building with gcc-12 build(linux/fedora): Reenable Cuda support by building with gcc-12 Jun 9, 2024
@Crashdummyy
Copy link
Contributor Author

 #21 246.4 input.cpp:(.text._ZN5platf11input_raw_t13clear_gamepadEi[_ZN5platf11input_raw_t13clear_gamepadEi]+0xad2): undefined reference to `std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace_cold(char*, unsigned long, char const*, unsigned long, unsigned long)'
#21 246.4 /usr/bin/ld: CMakeFiles/sunshine.dir/src/nvenc/nvenc_base.cpp.o: in function `nvenc::nvenc_base::nvenc_failed(_NVENCSTATUS) [clone .cold]':
#21 246.4 nvenc_base.cpp:(.text.unlikely+0xa5): undefined reference to `std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace_cold(char*, unsigned long, char const*, unsigned long, unsigned long)'
#21 246.4 /usr/bin/ld: CMakeFiles/sunshine.dir/src/nvenc/nvenc_base.cpp.o: in function `std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::insert(unsigned long, char const*)':
#21 246.4 nvenc_base.cpp:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE6insertEmPKc[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE6insertEmPKc]+0x10f): undefined reference to `std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace_cold(char*, unsigned long, char const*, unsigned long, unsigned long)'
#21 246.5 /usr/bin/ld: /usr/lib64/libboost_locale.so.1.83.0: undefined reference to `std::ios_base_library_init()@GLIBCXX_3.4.32'
#21 246.5 /usr/bin/ld: /usr/lib64/libboost_log.so.1.83.0: undefined reference to `__cxa_call_terminate@CXXABI_1.3.15'
#21 246.6 collect2: error: ld returned 1 exit status
#21 246.6 make[2]: *** [CMakeFiles/sunshine.dir/build.make:837: sunshine-0.0.0.ba6524c6aca2e9020a9e9b54d4433bd9e94d9e82] Error 1
#21 246.6 make[1]: *** [CMakeFiles/Makefile2:191: CMakeFiles/sunshine.dir/all] Error 2
#21 246.6 make[1]: *** Waiting for unfinished jobs....

Computer say no.

I bumped cuda from 12.4.0 to 12.5.0 but i doubt that this is the issue..

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.78%. Comparing base (539ca42) to head (ba6524c).
Report is 166 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2654      +/-   ##
=========================================
- Coverage    7.98%   7.78%   -0.21%     
=========================================
  Files          88      88              
  Lines       18039   18031       -8     
  Branches     8596    8596              
=========================================
- Hits         1441    1404      -37     
- Misses      13757   13872     +115     
+ Partials     2841    2755      -86     
Flag Coverage Δ
Linux 6.05% <ø> (ø)
Windows 3.76% <ø> (ø)
macOS-12 ?
macOS-13 8.92% <ø> (ø)
macOS-14 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@Crashdummyy
Copy link
Contributor Author

@ReenigneArcher
I'll close this pr for now.

I'll reopen one again when I either find a possibility to use a statically linked 13.2 boost lib additionally to cuda-gcc-c++ or when cuda 12.6 releases which hopefully supports gcc14

@ReenigneArcher
Copy link
Member

Thanks! I'm also working on statically linking boost in #2628 but facing some annoyances on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants