Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(win/video): support native YUV 4:4:4 encoding #2533

Merged
merged 8 commits into from
Aug 16, 2024

Resolve relevant SonarCloud warnings

fd58f6b
Select commit
Loading
Failed to load commit list.
Merged

feat(win/video): support native YUV 4:4:4 encoding #2533

Resolve relevant SonarCloud warnings
fd58f6b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 16, 2024 in 0s

9.67% (-0.02%) compared to e8c837f

View this Pull Request on Codecov

9.67% (-0.02%) compared to e8c837f

Details

Codecov Report

Attention: Patch coverage is 8.20896% with 492 lines in your changes missing coverage. Please review.

Project coverage is 9.67%. Comparing base (e8c837f) to head (fd58f6b).

Files Patch % Lines
src/platform/windows/display_vram.cpp 0.00% 163 Missing and 10 partials ⚠️
src/nvenc/nvenc_d3d11_on_cuda.cpp 0.00% 151 Missing ⚠️
src/nvenc/nvenc_base.cpp 0.00% 19 Missing and 23 partials ⚠️
src/nvenc/nvenc_d3d11_native.cpp 0.00% 36 Missing ⚠️
src/video.cpp 50.68% 22 Missing and 14 partials ⚠️
src/video_colorspace.cpp 0.00% 17 Missing and 1 partial ⚠️
src/nvhttp.cpp 0.00% 5 Missing and 5 partials ⚠️
src/nvenc/nvenc_utils.cpp 0.00% 6 Missing ⚠️
src/nvenc/nvenc_d3d11_on_cuda.h 0.00% 5 Missing ⚠️
src/nvenc/nvenc_d3d11.cpp 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2533      +/-   ##
=========================================
- Coverage    9.69%   9.67%   -0.02%     
=========================================
  Files          97     101       +4     
  Lines       17525   17898     +373     
  Branches     8204    8365     +161     
=========================================
+ Hits         1699    1732      +33     
- Misses      12988   13295     +307     
- Partials     2838    2871      +33     
Files Coverage Δ
src/nvenc/nvenc_encoded_frame.h 0.00% <ø> (ø)
src/nvenc/nvenc_base.h 0.00% <0.00%> (ø)
src/video.h 55.69% <87.50%> (+2.91%) ⬆️
src/nvenc/nvenc_d3d11.h 0.00% <0.00%> (ø)
src/rtsp.cpp 1.88% <0.00%> (-0.01%) ⬇️
src/utility.h 28.24% <0.00%> (-0.27%) ⬇️
src/platform/common.h 33.33% <0.00%> (-1.12%) ⬇️
src/nvenc/nvenc_d3d11.cpp 0.00% <0.00%> (-3.85%) ⬇️
src/nvenc/nvenc_d3d11_on_cuda.h 0.00% <0.00%> (ø)
src/nvenc/nvenc_utils.cpp 0.00% <0.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes