-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: Update resolution automation example text with auto refresh rate #2503
webui: Update resolution automation example text with auto refresh rate #2503
Conversation
…t refresh rate preference
I'm not sure it's wise to add this to the examples as users will blindly set the refresh rate, and possibly to unsupported refresh rates. |
Couldn't you say the same about the resolution itself? Static refresh rate guidance is there for 2 of 3 platforms today. Feels like setting it to auto and the client sending 60hz by default makes the guidance fairly sane. |
Oh btw - these tools won't enable a user to set a refresh rate that isn't advertised by the display to the OS. A weird number simply won't do anything. These commands are only able to set the same options as the user can set themselves in the OS UI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nightly #2503 +/- ##
========================================
Coverage 6.18% 6.18%
========================================
Files 86 86
Lines 17548 17548
Branches 8186 8186
========================================
Hits 1085 1085
- Misses 14652 15359 +707
+ Partials 1811 1104 -707
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
The Resolution Automation example text is inconsistent about refresh rate across platforms. The refresh rate flag is omitted for QRes Windows and suggested with a static 60 for xrandr (Linux) and displayplacer (Mac). Given the rise in average refresh rates on mobile devices I suspect users prefer seeing refresh rate handling guidance in the example commands.
Note that the Moonlight client apps typically default to 60 as the default refresh rate passed to Sunshine. Users with high refresh devices typically set a higher preference in their Moonlight client settings to feed >60 into the Sunshine prep command.
Screenshot
Issues Fixed or Closed
N/A
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.