Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macos/capture): support for capture display other than main display #2449

Merged
merged 19 commits into from
Apr 22, 2024

doc spacing issue fixed.

a755c7e
Select commit
Loading
Failed to load commit list.
Merged

feat(macos/capture): support for capture display other than main display #2449

doc spacing issue fixed.
a755c7e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 22, 2024 in 0s

6.17% (+0.01%) compared to 067efc7

View this Pull Request on Codecov

6.17% (+0.01%) compared to 067efc7

Details

Codecov Report

Attention: Patch coverage is 16.12903% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 6.17%. Comparing base (067efc7) to head (a755c7e).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2449      +/-   ##
==========================================
+ Coverage     6.16%   6.17%   +0.01%     
==========================================
  Files           86      86              
  Lines        17523   17542      +19     
  Branches      8169    8179      +10     
==========================================
+ Hits          1080    1083       +3     
+ Misses       15410   15362      -48     
- Partials      1033    1097      +64     
Files Coverage Δ
src/platform/linux/x11grab.cpp 26.03% <0.00%> (-2.86%) ⬇️
src/platform/macos/av_video.m 60.24% <62.50%> (+11.55%) ⬆️
src/platform/macos/display.mm 41.00% <0.00%> (-0.42%) ⬇️
src/platform/macos/input.cpp 2.39% <0.00%> (-0.17%) ⬇️

... and 16 files with indirect coverage changes