fix(windows/amf): Revert RC/HRD defaults; improve documentation & config parsing #2419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert RC and HRD defaults back to 'vbr_latency' and 'disabled' due to encoding artifacts or quality regressions noted on several cards.
Document all new and existing AMF options in the docs and UI. Rearrange AMF options to better reflect importance (Usage is primary) and group by relatedness; group RC and HRD together, group all other quality-related sub options together.
Various cleanups & fixes to AMF option parsing, including proper setting of defaults when invalid configuration is parsed.
Screenshot
Issues Fixed or Closed
Changes resolution of #1040 (requires user to manually enable RC and/or HRD due to regressions on many cards when HRD is enabled by default).
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.