Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows/amf): Revert RC/HRD defaults; improve documentation & config parsing #2419

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

psyke83
Copy link
Collaborator

@psyke83 psyke83 commented Apr 14, 2024

Description

  • Revert RC and HRD defaults back to 'vbr_latency' and 'disabled' due to encoding artifacts or quality regressions noted on several cards.

  • Document all new and existing AMF options in the docs and UI. Rearrange AMF options to better reflect importance (Usage is primary) and group by relatedness; group RC and HRD together, group all other quality-related sub options together.

  • Various cleanups & fixes to AMF option parsing, including proper setting of defaults when invalid configuration is parsed.

Screenshot

Screenshot_20240414_172232

Issues Fixed or Closed

Changes resolution of #1040 (requires user to manually enable RC and/or HRD due to regressions on many cards when HRD is enabled by default).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 6.61%. Comparing base (9e0182b) to head (344491a).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2419      +/-   ##
==========================================
- Coverage     6.77%   6.61%   -0.16%     
==========================================
  Files           86      86              
  Lines        17523   17523              
  Branches      8074    8030      -44     
==========================================
- Hits          1187    1159      -28     
- Misses       15393   15407      +14     
- Partials       943     957      +14     
Flag Coverage Δ
Linux 5.75% <0.00%> (ø)
Windows 2.04% <0.00%> (ø)
macOS-12 8.57% <0.00%> (-0.02%) ⬇️
macOS-13 7.78% <0.00%> (+0.01%) ⬆️
macOS-14 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/config.h 0.00% <ø> (ø)
src/config.cpp 4.50% <0.00%> (ø)

... and 10 files with indirect coverage changes

@psyke83 psyke83 force-pushed the hrd_nodefault branch 2 times, most recently from 9ef050b to d513188 Compare April 14, 2024 17:01
@psyke83 psyke83 marked this pull request as ready for review April 14, 2024 18:42
* Revert RC and HRD defaults back to 'vbr_latency' and 'disabled' due to
  encoding artifacts or quality regressions noted on several cards.

* Document all new and existing AMF options in the docs and UI. Rearrange
  AMF options to better reflect importance (Usage is primary) and group by
  relatedness; group RC and HRD together, group all other quality-related
  sub options together.

* Various cleanups & fixes to AMF option parsing, including proper setting of
  defaults when invalid configuration is parsed.
@ReenigneArcher ReenigneArcher changed the title win: amf: Revert RC/HRD defaults; improve documentation & config parsing fix(windows/amf): Revert RC/HRD defaults; improve documentation & config parsing Apr 19, 2024
@ReenigneArcher ReenigneArcher merged commit 87def6d into LizardByte:nightly Apr 19, 2024
52 of 53 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants