Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musl Linux fixes #2401

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Musl Linux fixes #2401

merged 3 commits into from
Apr 12, 2024

Conversation

istori1
Copy link
Contributor

@istori1 istori1 commented Apr 10, 2024

Description

Compilation error when attempting to compile in a https://chimera-linux.org/ environment.

/Sunshine/src/main.cpp:100:59: error: no template named 'codecvt_utf8' in namespace 'std'
  100 |   std::locale::global(std::locale(std::locale(), new std::codecvt_utf8<wchar_t>));
      |                                                      ~~~~~^
/Sunshine/src/main.cpp:338:2: error: expected '}'
  338 | }
      |  ^
/Sunshine/src/main.cpp:87:30: note: to match this '{'
   87 | main(int argc, char *argv[]) {
      |                              ^
2 errors generated.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@istori1 istori1 changed the title Add missing include Non-GNU Linux enablement Apr 11, 2024
@istori1 istori1 changed the title Non-GNU Linux enablement Non-GNU Linux fixes Apr 11, 2024
@istori1 istori1 changed the title Non-GNU Linux fixes Musl Linux fixes Apr 11, 2024
@istori1 istori1 marked this pull request as ready for review April 11, 2024 23:14
cgutman
cgutman previously approved these changes Apr 11, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.37%. Comparing base (d143232) to head (de13600).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2401      +/-   ##
==========================================
+ Coverage     7.35%   7.37%   +0.02%     
==========================================
  Files           95      95              
  Lines        18949   18949              
  Branches      8071    8082      +11     
==========================================
+ Hits          1393    1397       +4     
- Misses       15854   16152     +298     
+ Partials      1702    1400     -302     
Flag Coverage Δ
Linux 6.96% <ø> (+0.03%) ⬆️
Windows 2.01% <ø> (ø)
macOS-12 8.38% <ø> (-0.02%) ⬇️
macOS-13 7.70% <ø> (ø)
macOS-14 8.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

@cgutman cgutman merged commit 5c1bad7 into LizardByte:nightly Apr 12, 2024
51 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants