Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(tests): ensure tests can be disabled during build #2386

Conversation

ReenigneArcher
Copy link
Member

Description

Building tests could not be disabled due to cmake failures.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the build(tests)-ensure-tests-can-be-disabled-during-build branch from 09de04c to 78cd02c Compare April 8, 2024 16:27
@ReenigneArcher ReenigneArcher merged commit 7e26d2f into nightly Apr 8, 2024
48 of 49 checks passed
@ReenigneArcher ReenigneArcher deleted the build(tests)-ensure-tests-can-be-disabled-during-build branch April 8, 2024 23:17
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.23.0: CMake error when trying to build with tests disabled (-DBUILD_TESTS:BOOL=FALSE)
1 participant