Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): ensure unpairing takes effect without restart #2365

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Apr 5, 2024

Description

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 6.49%. Comparing base (3c13027) to head (9b386e3).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2365      +/-   ##
==========================================
+ Coverage     6.40%   6.49%   +0.09%     
==========================================
  Files           85      85              
  Lines        18378   18384       +6     
  Branches      8342    8348       +6     
==========================================
+ Hits          1177    1194      +17     
+ Misses       16147   16065      -82     
- Partials      1054    1125      +71     
Flag Coverage Δ
Linux 4.43% <0.00%> (+<0.01%) ⬆️
Windows 2.01% <0.00%> (+<0.01%) ⬆️
macOS-12 8.71% <16.66%> (?)
macOS-13 8.07% <16.66%> (-0.01%) ⬇️
macOS-14 8.38% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/crypto.h 0.00% <ø> (ø)
src/nvhttp.cpp 1.30% <33.33%> (-0.29%) ⬇️
src/crypto.cpp 0.37% <0.00%> (+0.37%) ⬆️

... and 16 files with indirect coverage changes

@ReenigneArcher ReenigneArcher added this to the v0.23.0 milestone Apr 5, 2024
@ReenigneArcher ReenigneArcher force-pushed the fix(security)-ensure-unpairing-takes-effect-without-restart branch from 0143ee8 to 100be39 Compare April 5, 2024 03:12
@ReenigneArcher ReenigneArcher requested a review from cgutman April 5, 2024 12:40
@ReenigneArcher ReenigneArcher force-pushed the fix(security)-ensure-unpairing-takes-effect-without-restart branch 3 times, most recently from 7cf35d7 to 006048b Compare April 6, 2024 02:48
@ReenigneArcher ReenigneArcher force-pushed the fix(security)-ensure-unpairing-takes-effect-without-restart branch from 006048b to 53717e9 Compare April 6, 2024 11:04
@ReenigneArcher ReenigneArcher force-pushed the fix(security)-ensure-unpairing-takes-effect-without-restart branch from 53717e9 to 9b386e3 Compare April 6, 2024 19:22
@ReenigneArcher ReenigneArcher merged commit b7aa811 into nightly Apr 6, 2024
51 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(security)-ensure-unpairing-takes-effect-without-restart branch April 6, 2024 20:39
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pairing only one device after unpair all devices pair all of them again without the need of a PIN
2 participants