Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update curl flag for macos portfile installation #2337

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

zanechua
Copy link
Contributor

@zanechua zanechua commented Mar 31, 2024

Description

Curl command needs to follow the redirect otherwise you'll get a 0-byte file

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.10%. Comparing base (991fab9) to head (357e9d0).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2337      +/-   ##
==========================================
- Coverage     6.11%   6.10%   -0.01%     
==========================================
  Files           85      85              
  Lines        18303   18303              
  Branches      8319    8319              
==========================================
- Hits          1119    1118       -1     
- Misses       15375   15688     +313     
+ Partials      1809    1497     -312     
Flag Coverage Δ
Linux 4.11% <ø> (ø)
Windows 1.51% <ø> (ø)
macOS-12 8.13% <ø> (-0.13%) ⬇️
macOS-13 7.46% <ø> (+0.05%) ⬆️
macOS-14 7.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 1329c51 into LizardByte:nightly Mar 31, 2024
51 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants