Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(windows): update devcon #2296

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 25, 2024

Description

Silent installer for DevCon, per Drawbackz/DevCon-Installer#10

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.98%. Comparing base (89e8b96) to head (0bcbac8).

Additional details and impacted files
@@            Coverage Diff             @@
##           nightly   #2296      +/-   ##
==========================================
- Coverage     6.10%   5.98%   -0.12%     
==========================================
  Files           85      85              
  Lines        18296   18292       -4     
  Branches      8316    8310       -6     
==========================================
- Hits          1117    1095      -22     
- Misses       15373   16159     +786     
+ Partials      1806    1038     -768     
Flag Coverage Δ
Linux 4.12% <ø> (ø)
Windows 1.51% <ø> (ø)
macOS-12 ?
macOS-13 7.40% <ø> (ø)
macOS-14 7.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci(windows)-update-devcon branch 17 times, most recently from 927d2ad to 8339f44 Compare March 26, 2024 21:27
@ReenigneArcher ReenigneArcher force-pushed the ci(windows)-update-devcon branch from 8339f44 to 0bcbac8 Compare March 26, 2024 21:41
@ReenigneArcher ReenigneArcher marked this pull request as ready for review March 27, 2024 02:47
@ReenigneArcher ReenigneArcher merged commit 13aea3c into nightly Mar 27, 2024
51 checks passed
@ReenigneArcher ReenigneArcher deleted the ci(windows)-update-devcon branch March 27, 2024 02:47
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant