-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use icon caching for system tray. #2238
Use icon caching for system tray. #2238
Conversation
858ff0b
to
e9b5ea2
Compare
@brycerocky thank you for the PRs. Once you sign the CLA we can run the CI. |
Could you update the tray submodule back to master branch of our tray repo? |
e9b5ea2
to
ad4d0c7
Compare
Thanks for the heads up @ReenigneArcher . I've gone ahead and removed the module update. |
Oh, I meant can you update it to the commit we merged into the master branch. |
ad4d0c7
to
45417a5
Compare
Ah my apologies. First time working with submodules. I've gone ahead and updated accordingly. |
45417a5
to
a775eeb
Compare
No worries. Submodules can be tricky. One more thing, can you fix the lint warnings? https://github.com/LizardByte/Sunshine/actions/runs/8224979468/job/22489455765?pr=2238#step:5:19 |
a775eeb
to
1a06193
Compare
Should be updated now. Thanks! |
This changelist declares the icons to be used by the system tray so that the tray logic can pre-fetch the resources during init.
1a06193
to
956732f
Compare
Description
This changelist declares the icons to be used by the system tray so that the tray logic can pre-fetch the resources during init. This prevents the icons from being fetched on demand, which can lead to DRM issues from invoking the shell API.
Screenshot
There are no visible changes to the user
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.