Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use icon caching for system tray. #2238

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

brycerocky
Copy link
Contributor

@brycerocky brycerocky commented Mar 10, 2024

Description

This changelist declares the icons to be used by the system tray so that the tray logic can pre-fetch the resources during init. This prevents the icons from being fetched on demand, which can lead to DRM issues from invoking the shell API.

Screenshot

There are no visible changes to the user

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2024

CLA assistant check
All committers have signed the CLA.

@ReenigneArcher
Copy link
Member

@brycerocky thank you for the PRs. Once you sign the CLA we can run the CI.

@ReenigneArcher
Copy link
Member

Could you update the tray submodule back to master branch of our tray repo?

@ReenigneArcher ReenigneArcher added this to the v0.22.1 milestone Mar 10, 2024
@brycerocky
Copy link
Contributor Author

Could you update the tray submodule back to master branch of our tray repo?

Thanks for the heads up @ReenigneArcher . I've gone ahead and removed the module update.

@ReenigneArcher
Copy link
Member

Oh, I meant can you update it to the commit we merged into the master branch.

@brycerocky
Copy link
Contributor Author

Oh, I meant can you update it to the commit we merged into the master branch.

Ah my apologies. First time working with submodules. I've gone ahead and updated accordingly.

@ReenigneArcher
Copy link
Member

No worries. Submodules can be tricky.

One more thing, can you fix the lint warnings? https://github.com/LizardByte/Sunshine/actions/runs/8224979468/job/22489455765?pr=2238#step:5:19

@brycerocky
Copy link
Contributor Author

No worries. Submodules can be tricky.

One more thing, can you fix the lint warnings? https://github.com/LizardByte/Sunshine/actions/runs/8224979468/job/22489455765?pr=2238#step:5:19

Should be updated now. Thanks!

This changelist declares the icons to be used by the system tray so that
the tray logic can pre-fetch the resources during init.
@ReenigneArcher ReenigneArcher merged commit bc0a478 into LizardByte:nightly Mar 10, 2024
49 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Madden 24 game window disappears on session resume
3 participants