Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add winget releaser action #215

Merged
merged 2 commits into from
Aug 7, 2022
Merged

Add winget releaser action #215

merged 2 commits into from
Aug 7, 2022

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jun 19, 2022

Description

Continuation of #203 since it cannot be reopened.

This action automatically generates manifests for WinGet Community Repository (microsoft/winget-pkgs) and submits them.

Before merging this:

  1. Add a PAT with public_repo scope as a repository secret named WINGET_TOKEN (or rename the secret name in the workflow). @LizardByte-bot's PAT is used in the workflow.
  2. Fork https://github.com/microsoft/winget-pkgs under @LizardByte
  3. Make sure the PAT owner has signed the Contributor License Agreement for winget-pkgs.

If you would like to read about this action further, the documentation is here, and the source code is here.

If you want to see an example of a PR created using this action, see microsoft/winget-pkgs/pulls (Pull request has been automatically created using 🛫 WinGet Releaser).

Notes

You would need to change the Publisher entry of the manifest to LizardByte on the next release (to match with the vendor info). You can add the change alongside the PR that Winget will automatically create in the next release.

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

@sitiom sitiom marked this pull request as ready for review June 30, 2022 01:28
@CLAassistant
Copy link

CLAassistant commented Jul 30, 2022

CLA assistant check
All committers have signed the CLA.

@sitiom
Copy link
Contributor Author

sitiom commented Jul 30, 2022

Updated identifier to LizardByte.Sunshine. I have also made a PR to rename it in winget-pkgs (microsoft/winget-pkgs#68000, microsoft/winget-pkgs#68001).

@sitiom
Copy link
Contributor Author

sitiom commented Jul 30, 2022

Note: You need to change the Publisher entry of the manifest to LizardByte on the next release (to match with the vendor info). You can add the change alongside the PR that Winget will automatically create in the next release.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 3, 2022

Separated the action to a separate workflow, as it currently only works with release events (vedantmgoyal9/winget-releaser#3). I have also put GH_BOT_TOKEN as the token to use. @ReenigneArcher you wouldn't mind that, right?

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Aug 3, 2022

Separated the action to a separate workflow, as it currently only works with release events (vedantmgoyal2009/winget-releaser#3). I have also put GH_BOT_TOKEN as the token to use. @ReenigneArcher you wouldn't mind that, right?

GH_BOT_TOKEN is correct for this org. Thanks.

Edit: I think this is a cleaner approach than integrating it with the CI. I would like to understand more how the action actually works. It also seems as if there are some details somewhere that need to be updated outside of this action (not entirely sure).

@sitiom
Copy link
Contributor Author

sitiom commented Aug 3, 2022

I would like to understand more how the action actually works. It also seems as if there are some details somewhere that need to be updated outside of this action (not entirely sure).

My description in #215 (comment) contains everything that you need to know about this action and everything that you need to do beforehand.

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • repo forked
  • CLA signed by bot account

@ReenigneArcher ReenigneArcher merged commit 8164c09 into LizardByte:nightly Aug 7, 2022
@sitiom sitiom deleted the winget-releaser branch August 8, 2022 02:20
@sitiom
Copy link
Contributor Author

sitiom commented Sep 28, 2022

@ReenigneArcher There is an extra step: You should keep the fork regularly updated with Pull. See vedantmgoyal9/winget-releaser#32

@ReenigneArcher
Copy link
Member

@sitiom do you mind creating an issue there? otherwise I will lose track of this. https://github.com/LizardByte/winget-pkgs/issues

@sitiom sitiom mentioned this pull request Sep 29, 2022
7 tasks
@sitiom
Copy link
Contributor Author

sitiom commented Sep 29, 2022

I'll just mention it alongside the PR in #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants