Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backwards compatibility for NVENC APIs back to Video Codec SDK v11.0 #2143

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Feb 15, 2024

Description

This implements a backwards compatibility solution for NvEncode API similar to what OBS did in obsproject/obs-studio#7430 to reintroduce support for driver versions between 456.71 (minimum for v11.0) and 522.25 (minimum for v12.0). The net result is we now retain compatibility with drivers going back to October 2020.

I verified that AV1 still works as expected on my RTX 4080, while my RTX 2080 on extremely old drivers (456.71) can now stream with NVENC.

Screenshot

Issues Fixed or Closed

Fixes #2141
Fixes #2056

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

…SDK v11.0

This allows NVENC on drivers 456.71 (October 2020) and later.
@cgutman cgutman merged commit d1a6358 into LizardByte:nightly Feb 17, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant