feat(ui): add hash handler for configuration ids #2002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a hash handler to allow navigating to ids which are not normally available unless the correct tab is selected. Originally I was going to dynamically determine the closest "tab" to the element in the hash, but the element is not available unless the tab is already loaded, so I had to add a mapping of each tab to the options that they contain.
In adding this new mapping, I decided that the
defaultConfig
mapping could be moved to this new mapping. A small bug was also discovered and fixed when moving thedefaultConfig
, which was that the values that were not string encoded previously would not be evaluate properly when comparing the default value to the value in the UI.The hash watcher can be tested by visiting
https://localhost:47990/config/#encoder
. This should work when the page is loaded fresh, as well as if you already on theconfig
page and then add the#encoder
hash.Moving forward, all config options, and tabs should have a matching
id
, which will be referenced in the docs. See #2000.Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.