Install icons to hicolor theme on Linux #1669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now Sunshine installs icons directly to
/usr/share/icons
. This is generally discouraged. According to freedesktop spec, well-behaved applications should put their icons under/usr/share/icons/hicolor
directory instead of/usr/share/icons
. This PR changes the installation paths as following:/usr/share/icons/hicolor/scalable/apps
/usr/share/icons/hicolor/scalable/status
Note that I also made a copy of
sunshine.svg
and renamed it tosunshine-tray.svg
. This allows us to have two separate icons:sunshine.svg
for DE main menu andsunshine-tray.svg
for tray. So even in case when Sunshine is compiled without tray support,sunshine.svg
will be still installed and displayed in the main menu. In future we might also want distinct Sunshine icons, e.g. larger colorful icon for the main menu and smaller monochrome icon for tray.Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.