Specify the source address for outbound audio and video traffic #1569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements proper source address preservation for video and audio traffic. Previously, outgoing traffic would be subject to regular OS routing logic, so it could be sent with a source address different than the address where incoming traffic from the host was received.
This work is also necessary to unblock IPv6 support in #571 due to IPv6 temporary addresses being preferred as source addresses for outbound traffic.
Tested:
send_batch()
and fallbacksend()
path)send_batch()
withUDP_SEGMENT
,send_batch()
withoutUDP_SEGMENT
, and fallbacksend()
path)send()
only becausesend_batch()
is unimplemented)Screenshot
Issues Fixed or Closed
Fixes #1568
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.