Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the source address for outbound audio and video traffic #1569

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Aug 25, 2023

Description

This PR implements proper source address preservation for video and audio traffic. Previously, outgoing traffic would be subject to regular OS routing logic, so it could be sent with a source address different than the address where incoming traffic from the host was received.

This work is also necessary to unblock IPv6 support in #571 due to IPv6 temporary addresses being preferred as source addresses for outbound traffic.

Tested:

  • Windows (send_batch() and fallback send() path)
  • Linux (send_batch() with UDP_SEGMENT, send_batch() without UDP_SEGMENT, and fallback send() path)
  • macOS (send() only because send_batch() is unimplemented)

Screenshot

Issues Fixed or Closed

Fixes #1568

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman cgutman merged commit ebb6a7c into LizardByte:nightly Aug 26, 2023
@cgutman cgutman mentioned this pull request Aug 26, 2023
11 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant