Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Manifest improvements #1557

Merged

Conversation

TheElixZammuto
Copy link
Contributor

Description

This PR improves the manifest bundled in Windows using the info provided by CMake and the Windows documentation: https://learn.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource

In this way the exe info gets populated by the version, and both the notification balloon and the task manager have the correct name for Sunshine

Screenshot

2023-08-19 14_20_52-Task Manager
2023-08-19 14_20_20-sunshine exe Properties

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher merged commit a84dea3 into LizardByte:nightly Aug 19, 2023
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Aug 22, 2023
@TheElixZammuto TheElixZammuto deleted the manifest-improvements branch September 14, 2023 20:31
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants