Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): fix ArchLinux image cache #1554

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

ReenigneArcher
Copy link
Member

Description

Fix ArchLinux Docker image cache issue, where it would build Sunshine two times (on each build step). Adding --needed to pacman command should prevent re-installing already installed packages.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@LizardByte-bot
Copy link
Member

LizardByte-bot commented Aug 17, 2023

Qodana success
Results:
- js
- python

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Dependencies licenses

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
@fortawesome/fontawesome-free 6.4.0 OFL-1.1-no-RFN
@popperjs/core 2.11.8 MIT
bootstrap 5.3.0 MIT
vue 2.6.12 MIT
Contact Qodana team

Contact us at [email protected]

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Qodana for Python

It seems all right 👌

No new problems were found according to the checks applied

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@ReenigneArcher ReenigneArcher force-pushed the ci(docker)-fix-ArchLinux-image-cache branch 2 times, most recently from 3acf23f to 852a19d Compare August 17, 2023 18:02
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Aug 17, 2023

This doesn't actually improve the build time, but it probably doesn't hurt anything.

Edit: Reduced build time by not caching sunshine-base layer. Not sure what that will do to size of GitHub cache... but it builds faster anyway.

@ReenigneArcher ReenigneArcher force-pushed the ci(docker)-fix-ArchLinux-image-cache branch 2 times, most recently from e11a048 to 4601bff Compare August 18, 2023 00:35
@ReenigneArcher ReenigneArcher force-pushed the ci(docker)-fix-ArchLinux-image-cache branch from 4601bff to a879da3 Compare August 18, 2023 00:54
@ReenigneArcher ReenigneArcher marked this pull request as ready for review August 18, 2023 01:12
@ReenigneArcher ReenigneArcher merged commit 5b93265 into nightly Aug 18, 2023
@ReenigneArcher ReenigneArcher deleted the ci(docker)-fix-ArchLinux-image-cache branch August 18, 2023 01:50
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants