Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): free additional space on runners #1450

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jul 16, 2023

Description

This PR frees additional space on GitHub runners for docker builds, as some docker images were failing to build when building multiple architectures (on push events).

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@LizardByte-bot
Copy link
Member

LizardByte-bot commented Jul 16, 2023

Qodana success
Results:
- python
- js

@ReenigneArcher ReenigneArcher force-pushed the build(docker)-free-additional-space-on-runners branch from 984e79c to d50379d Compare July 16, 2023 01:47
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Jul 16, 2023

Changes to ci-docker.yml needed to be added to .github repo LizardByte/.github#232.

@ReenigneArcher ReenigneArcher force-pushed the build(docker)-free-additional-space-on-runners branch 4 times, most recently from 9e123b8 to b17e2fd Compare July 16, 2023 02:27
@ReenigneArcher ReenigneArcher self-assigned this Jul 16, 2023
@ReenigneArcher ReenigneArcher force-pushed the build(docker)-free-additional-space-on-runners branch from b17e2fd to 56ed71e Compare July 17, 2023 23:57
@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 18, 2023 19:01
@ReenigneArcher ReenigneArcher merged commit 48f05aa into nightly Jul 18, 2023
@ReenigneArcher ReenigneArcher deleted the build(docker)-free-additional-space-on-runners branch July 18, 2023 19:01
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants