Input extensions for controller touchpad, battery, RGB LEDs, and motion events #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgutman
force-pushed
the
controller_extensions
branch
from
1a6cbfa to
20103b1
Compare
cgutman
force-pushed
the
controller_extensions
branch
2 times, most recently
from
0490043 to
0b6edeb
Compare
cgutman
force-pushed
the
controller_extensions
branch
from
0b6edeb to
eb735c5
Compare
cgutman
force-pushed
the
controller_extensions
branch
from
eb735c5 to
cf173a0
Compare
cgutman
added
the
protocol update
cgutman
force-pushed
the
controller_extensions
branch
from
cf173a0 to
6ca37b4
Compare
We may get activeGamepadMask changes out of order between different controller channels, so only check the bit of the mask corresponding to the controller number specified in the event itself. This also fixes the "ControllerNumber not allocated" warning each time a gamepad is removed.
We need to use the client-relative index rather than the global index when sending feedback to the client.
cgutman
force-pushed
the
controller_extensions
branch
from
6ca37b4 to
cb7c3a7
Compare
|
I'm going to merge this after CI completes to let it bake in nightly. I've done integration testing for all the new features with Moonlight Qt and Moonlight Android with Sunshine on Windows and also verified that no gamepad regressions were introduced on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for many new controller features included in recent protocol extensions, including:
The core plumbing work is done in this PR along with a Windows implementation of these features using ViGEmBus. @ABeltramo mentioned he wanted to take a stab at the Linux implementation.
This PR also fixes a bug that prevented rumble from working correctly for all gamepads when multiple clients are streaming at once.
Screenshot
Issues Fixed or Closed
Resolves #1200
Resolves #979
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.