-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): replace libboost chrono and thread with standard chrono and thread #1364
Conversation
Thank you for the PR. I kind of think the solution is to switch to the standard chrono instead of boost... Unless I'm missing something. Not to mention if we were to fix it this way, we also need to fix the rpm. |
Thanks for lighting fast review. I didn't really look at the code much at first. I just got this error I now see that the code uses |
I'm not quite sure how it linked to boost chrono as it's not even installed in the build environment. https://github.com/LizardByte/Sunshine/blob/master/docker/ubuntu-20.04.dockerfile#L39 There might be a compile warning that doesn't fail the build and it is harder to detect. But I think boost chrono was just used in 2 files. Probably the solution is to just switch those to standard chrono. |
Makes a lot more sense now, I've done as suggested in the last two commits. |
It looks like the boost threading doesn't like the std time. I've switched it to use std threading too. After a quick search, it seems like |
Sorry about the crashes with the CI, I've done a manual launch on my fork and it seems to work now https://github.com/Era-Dorta/Sunshine/actions/runs/5248057310 |
Is there anything else I should do to move this forwards? |
I just need to review it, which might take some time. There were some ci failures (cancelled) for some reason. |
@ReenigneArcher Do you think this could be released as a hotfix? Version 0.20.0 is broken for a lot of people (me including) because of this issue. |
We don't do hot fixes and this has not been merged yet. You can manually install the missing dependency and sunshine will work fine. |
…d thread (LizardByte#1364) Co-authored-by: ReenigneArcher <[email protected]>
…d thread (LizardByte#1364) Co-authored-by: ReenigneArcher <[email protected]>
Description
Sunshine crashes on Ubuntu 22.04 due a missing lib boost dependency. This PR adds the missing dependency for the deb packages.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.