config: only save non default values #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
commented
Mar 10, 2023
| @@ -1050,33 +1055,57 @@ <h1 class="my-4">Configuration</h1> | |||
| this.resolutions.join("," + nl + " ") + | |||
| nl + | |||
| "]"; | |||
| this.config.fps = JSON.stringify(this.fps); | |||
| // remove quotes from values in fps | |||
| this.config.fps = JSON.stringify(this.fps).replace(/"/g, ""); | |||
There was a problem hiding this comment.
This fixes a possible bug where new FPS values were added surrounded by quotes, whereas the default values where without quotes.
| }, | ||
| save() { | ||
| this.saved = this.restarted = false; | ||
| this.serialize(); | ||
|
|
||
| // create a temp copy of this.config to use for the post request | ||
| let config = JSON.parse(JSON.stringify(this.config)) |
There was a problem hiding this comment.
A temp copy of the config is created, because if we delete this.config[key], the values are removed from the UI once you save them.
| }).then((r) => { | ||
| if (r.status === 200) this.saved = true; | ||
| }); | ||
| }, | ||
| apply() { | ||
| this.saved = this.restarted = false; | ||
| this.serialize(); | ||
| fetch("/api/config", { |
There was a problem hiding this comment.
This was removed, since the user must already click "Save" for the "Apply" button to appear... but we will save again anyway just to be safe (but without repeating code).
ReenigneArcher
force-pushed
the
config-only-save-non-default-values
branch
from
6debd1a to
e18358d
Compare
This was referenced Mar 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only save non default config values.
Also fixes a potential issue where new FPS values were quoted, as discovered when reviewing #1002.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.