Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly build completely broke controller support #1407

Closed
3 tasks done
lyndonguitar opened this issue Jun 30, 2023 · 8 comments · Fixed by #1334
Closed
3 tasks done

Nightly build completely broke controller support #1407

lyndonguitar opened this issue Jun 30, 2023 · 8 comments · Fixed by #1334
Labels
fixed This issue has been fixed and will be available in the next release.

Comments

@lyndonguitar
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your issue described in the documentation?

  • I have read the documentation

Is your issue present in the nightly release?

  • This issue is present in the nightly release

Describe the Bug

automated nightly release - 2023-06-28T02:12:10Z - 12e6774

completely broke controller support, controllers are not calibrated anymore. reverting to latest stable version fixes it

Expected Behavior

Controller should work and should be properly calibrated

Additional Context

joysticks are wonky, buttons are wrongly mapped, not work as intended

Host Operating System

Windows

Operating System Version

Windows

Architecture

64 bit

Sunshine commit or version

automated nightly release - 2023-06-28T02:12:10Z - 12e6774

Package

Windows - installer

GPU Type

Nvidia

GPU Model

RTX 3080

GPU Driver/Mesa Version

535.98

Capture Method (Linux Only)

No response

Config

its empty

Apps

No response

Relevant log output

was not able to get it when it was not working
@cgutman
Copy link
Collaborator

cgutman commented Jul 2, 2023

We'll need more information about your setup.

What client version are you using? What controller is connected to your client? What controller do you have Sunshine set to emulate?

Which buttons and axes are not mapped correctly? What are those incorrectly mapped buttons/axes actually mapped to?

@Lucide
Copy link

Lucide commented Jul 6, 2023

  • Windows 10 host, xbox 360 gamepad emulation
  • "xbox series x" controller (wireless/wired), classic xbox 360 wired controller
  • android, linux, windows clients

Button mapping is scrambled at least from build 11aedf5.

The vertical left axis acts as the right horizontal axis, and the left horizontal acts as the left vertical axis. Basically the same as moonlight's !822. The d-pad and face buttons are ok.

This is different from the scrambled mappings of cabled-vs-bluetooth controllers found with certain games/situations (where the stick axis are fine but the shoulder buttons/axis and the d-pad are incorrect).

cgutman added a commit to cgutman/LB_Sunshine that referenced this issue Jul 7, 2023
This has the side-effect of fixing LizardByte#1407 due to the incorrect assumption that
it's safe to cast our gamepad_state_t to a XUSB_REPORT.
cgutman added a commit to cgutman/LB_Sunshine that referenced this issue Jul 7, 2023
This has the side-effect of fixing LizardByte#1407 due to the incorrect assumption that
it's safe to cast our gamepad_state_t to a XUSB_REPORT.
@cgutman
Copy link
Collaborator

cgutman commented Jul 7, 2023

Please test this build from #1426 which should fix the issue: https://github.com/LizardByte/Sunshine/suites/14124093845/artifacts/790595658

@Lucide
Copy link

Lucide commented Jul 7, 2023

Fixed in my use cases🙂

@erictbar
Copy link

erictbar commented Jul 7, 2023

I had the same issue and this test build fixed it for me

Host: Windows 11 Pro 22H2 22621.1928, Latest nightly of Sunshine
Clients:

  • Nintendo Switch running Android 11, wired connected JoyCons
  • Xbox Series S running Moonlight for Xbox UWP, Xbox USB-C controller over Bluetooth

The game I noticed the issue with was Mass Effect Legendary Edition. Moving around with the L and R sticks was completely broken. When I went to controller settings in Windows and went to calibrate, I was able to get the Left controller to the upper left, but would not find the lower left.

@Stono
Copy link

Stono commented Jul 8, 2023

Hey that link 404's for me so can't test it

@ns6089
Copy link
Contributor

ns6089 commented Jul 8, 2023

Hey that link 404's for me so can't test it

https://github.com/LizardByte/Sunshine/actions/runs/5482586470?pr=1426 is semi-permanent link, select sunhine-windows artifact at the bottom of the screen

cgutman added a commit to cgutman/LB_Sunshine that referenced this issue Jul 8, 2023
This has the side-effect of fixing LizardByte#1407 due to the incorrect assumption that
it's safe to cast our gamepad_state_t to a XUSB_REPORT.
cgutman added a commit that referenced this issue Jul 8, 2023
This has the side-effect of fixing #1407 due to the incorrect assumption that
it's safe to cast our gamepad_state_t to a XUSB_REPORT.
@cgutman cgutman added the fixed This issue has been fixed and will be available in the next release. label Jul 9, 2023
@LizardByte-bot
Copy link
Member

This issue has been fixed and will be available in the next release.

@ReenigneArcher ReenigneArcher mentioned this issue Sep 13, 2023
7 tasks
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this issue Jun 6, 2024
This has the side-effect of fixing LizardByte#1407 due to the incorrect assumption that
it's safe to cast our gamepad_state_t to a XUSB_REPORT.
e-dong pushed a commit to e-dong/Sunshine that referenced this issue Jul 26, 2024
This has the side-effect of fixing LizardByte#1407 due to the incorrect assumption that
it's safe to cast our gamepad_state_t to a XUSB_REPORT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed This issue has been fixed and will be available in the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants