chore(ui): fixes code review

LizardByte · May 13, 2024 · 82b6a25 · 82b6a25
1 parent 06e8133
commit 82b6a25
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 15 deletions.
diff --git a/src_assets/common/assets/web/Navbar.vue b/src_assets/common/assets/web/Navbar.vue
@@ -1,5 +1,5 @@
 <template>
-    <nav class="navbar navbar-expand-lg navbar-background">
+    <nav class="navbar navbar-expand-lg navbar-background header">
         <div class="container-fluid">
             <a class="navbar-brand" href="/" title="Sunshine">
                 <img src="/images/logo-sunshine-45.png" height="45" alt="Sunshine">
@@ -56,25 +56,25 @@ export default {
 </script>
 
 <style>
-[data-bs-theme=light] .navbar-background {
+.navbar-background {
   background-color: #ffc400
 }
 
-[data-bs-theme=dark] .navbar-background{
-  background-color: color-mix(in srgb, #ffc400, black 20%);
+.header .nav-link {
+  color: var(--bs-dark);
 }
 
-@media (prefers-color-scheme: dark) {
-  .navbar-background{
-    background-color: color-mix(in srgb, #ffc400, black 20%);
-  }
+.header .nav-link.active {
+  color: var(--bs-dark) !important;
+  font-weight: 500;
 }
 
-.nav-link.active {
-    font-weight: 500;
+.header .nav-link:hover {
+  color: var(--bs-dark) !important;
+  font-weight: 500;
 }
 
 .form-control::placeholder {
-    opacity: 0.5;
+  opacity: 0.5;
 }
 </style>
diff --git a/src_assets/common/assets/web/ThemeToggle.vue b/src_assets/common/assets/web/ThemeToggle.vue
@@ -1,5 +1,4 @@
 <script setup>
-
 import { loadAutoTheme, setupThemeToggleListener } from './theme'
 import { onMounted } from 'vue'
 
@@ -44,5 +43,4 @@ onMounted(() => {
 </template>
 
 <style scoped>
-
-</style>
+</style>
diff --git a/src_assets/common/assets/web/theme.js b/src_assets/common/assets/web/theme.js
@@ -81,4 +81,4 @@ export function loadAutoTheme() {
             showActiveTheme(getPreferredTheme())
         })
     })()
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -81,4 +81,4 @@ export function loadAutoTheme() { @@
                 showActiveTheme(getPreferredTheme())
             })
         })()
-    }
+    }