Skip to content

Commit

Permalink
Fixup for PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
cgutman committed Oct 24, 2024
1 parent 07f0f6e commit 36e31c6
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions src/rtsp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ namespace rtsp_stream {
* @param session The session to remove.
*/
void
remove(std::shared_ptr<stream::session_t> &session) {
remove(const std::shared_ptr<stream::session_t> &session) {

Check warning on line 602 in src/rtsp.cpp

View check run for this annotation

Codecov / codecov/patch

src/rtsp.cpp#L602

Added line #L602 was not covered by tests
auto lg = _session_slots.lock();
_session_slots->erase(session);
}
Expand All @@ -609,9 +609,10 @@ namespace rtsp_stream {
* @param session The session to insert.
*/
void
insert(std::shared_ptr<stream::session_t> &session) {
insert(const std::shared_ptr<stream::session_t> &session) {

Check warning on line 612 in src/rtsp.cpp

View check run for this annotation

Codecov / codecov/patch

src/rtsp.cpp#L612

Added line #L612 was not covered by tests
auto lg = _session_slots.lock();
_session_slots->emplace(session);
BOOST_LOG(info) << "New streaming session started [active sessions: "sv << _session_slots->size() << ']';
}

private:
Expand Down Expand Up @@ -639,10 +640,6 @@ namespace rtsp_stream {
server.session_clear(launch_session_id);
}

/**
* @brief Get the number of active sessions.
* @return Count of active sessions.
*/
int
session_count() {
// Ensure session_count is up-to-date
Expand All @@ -651,9 +648,6 @@ namespace rtsp_stream {
return server.session_count();
}

/**
* @brief Terminates all running streaming sessions.
*/
void
terminate_sessions() {
server.clear(true);

Check warning on line 653 in src/rtsp.cpp

View check run for this annotation

Codecov / codecov/patch

src/rtsp.cpp#L652-L653

Added lines #L652 - L653 were not covered by tests
Expand Down

0 comments on commit 36e31c6

Please sign in to comment.