Checking bounding box hit every time before checking mesh hit. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DenchiSoft We are going to approve your pull request. Please wait for a while while we check the operation for it. Sincerely, |
Fixed unnecessary changes.
ono-at-live2d-com
approved these changes
Dec 18, 2020
wada-at-live2d-com
approved these changes
Dec 18, 2020
|
We have seen performance improvements with your Pull Request. Sincerely, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks if the the intersection is within the bounding box before checking if it is within the mesh even if the CubismRaycastable has CubismRaycastablePrecision.Triangles set as Precision, potentially ruling out CubismDrawables without doing the costly mesh check.
It comes at a small overhead in general, but for my use-case (complex models with many vertices, all Drawables are Raycastable), not having this pre-check with the bounding box lags the application for ~0.5 seconds on mobile every time I raycast the model.